Skip to content

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Sep 16, 2025

Add peft as HF lib, so interlinks like

[`~peft.PeftConfig`]

are properly rendered as links to: PeftConfig

As an example, see currently how it is rendered in TRL docs: https://huggingface.co/docs/trl/v0.23.0/en/sft_trainer#trl.SFTTrainer

Screenshot from 2025-09-16 15-39-41

contrary to, e.g., ~datasets.Dataset:

Screenshot from 2025-09-16 15-42-55

@albertvillanova
Copy link
Member Author

CC: @BenjaminBossan

@Vaibhavs10 Vaibhavs10 requested a review from mishig25 November 3, 2025 11:10
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albertvillanova albertvillanova merged commit c63f294 into huggingface:main Nov 3, 2025
4 checks passed
@albertvillanova
Copy link
Member Author

After the merge of this PR, the interlinks work as expected: https://huggingface.co/docs/trl/main/en/sft_trainer#trl.SFTTrainer.peft_config

Screenshot from 2025-11-04 11-08-56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants